lumberyard icon indicating copy to clipboard operation
lumberyard copied to clipboard

Include MSVC debugging files in MSVC solution through WAF instead of using a batch script

Open yuriy0 opened this issue 6 years ago • 1 comments

Issue #, if available:

Description of changes: Lumberyard very helpfully contains natvis files which define how AZStd data types are displayed in the MSVC debugger. However, currently the only way to install these is with a batch script. There are not included in the MSVC solution generated by Waf.

Using this script is very inconvenient for many reasons:

  • you have to know it exists!
  • it installs to the global MSVC natvis storage locations. This effectively causes different installations of LY to clobber each others’ natvis files.
  • you have to re-run it if you change the natvis files
  • you have to change it if you add new natvis files (see first point about not knowing it exists)
  • you cannot live-edit the natvis files installed with the batch script while debugging in MSVC

On the other hand, if they were simply included in the generated solution by Waf, all of these problems would be solved. This is what this merge request does.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

yuriy0 avatar Aug 26 '19 20:08 yuriy0

Hi @yuriy0, thanks for contributing to LY we'll take a look at the change.

sconel avatar Aug 27 '19 18:08 sconel