graph-explorer icon indicating copy to clipboard operation
graph-explorer copied to clipboard

Fix error formatting when HTML response

Open kmcginnes opened this issue 9 months ago • 2 comments

Description

If an error response contains HTML content it should be ignored, since there is no consistent way to get useful content out of the HTML.

  • Fix dialog width and other styles for error details

Validation

  • Verified using html response stubbed out locally on gremlin endpoint
  • Added tests

Related Issues

  • Resolves #891

Check List

  • [x] I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • [x] I have run pnpm checks to ensure code compiles and meets standards.
  • [x] I have run pnpm test to check if all tests are passing.
  • [ ] I have covered new added functionality with unit tests if necessary.
  • [x] I have added an entry in the Changelog.md.

kmcginnes avatar Apr 25 '25 20:04 kmcginnes

LGTM just had a small comment

andreachild avatar Apr 25 '25 20:04 andreachild

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.85%. Comparing base (46372f5) to head (d4a0b06). Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
packages/graph-explorer/src/components/Dialog.tsx 0.00% 2 Missing :warning:
...aph-explorer/src/connector/fetchDatabaseRequest.ts 90.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   20.96%   30.85%   +9.89%     
==========================================
  Files         523      534      +11     
  Lines       22442    23823    +1381     
  Branches     1198     1423     +225     
==========================================
+ Hits         4704     7350    +2646     
+ Misses      17494    16346    -1148     
+ Partials      244      127     -117     
Flag Coverage Δ
unittests 30.85% <75.00%> (+9.89%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 25 '25 21:04 codecov[bot]