aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard

Remove the default use of the legacy signer

Open sugmanue opened this issue 1 year ago • 1 comments

Motivation and Context

Removes the use of the Aws4Signer class for the default polly presigner. Instead we fabricate a SelectedAuthScheme and delegate to the signer following the new SRA I&A model.

Modifications

Testing

There are already existing tests, added another one to validate that the new and old singing strategies works the same by testing using a fixed clock and signature and by using a request level override.

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

Checklist

  • [ ] I have read the CONTRIBUTING document
  • [ ] Local run of mvn install succeeds
  • [ ] My code follows the code style of this project
  • [ ] My change requires a change to the Javadoc documentation
  • [ ] I have updated the Javadoc documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] All new and existing tests passed
  • [ ] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • [ ] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [ ] I confirm that this pull request can be released under the Apache 2 license

sugmanue avatar Feb 21 '24 22:02 sugmanue

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 23 '24 23:02 sonarqubecloud[bot]