aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard

Missing configuration in S3CrtAsyncClient

Open abialas opened this issue 2 years ago • 0 comments

Describe the feature

We used to be able to configure writeTimeout and chunkedEncodingEnabled using S3AsyncClient with NettyNioAsyncHttpClient:

SdkAsyncHttpClient httpClient =
    NettyNioAsyncHttpClient.builder()
        .writeTimeout(writeTimeout)
        .maxConcurrency(maxConcurrency)
        .build();
S3Configuration serviceConfiguration =
    S3Configuration.builder()
        .checksumValidationEnabled(checksumValidationEnabled)
        .chunkedEncodingEnabled(chunkedEncodingEnabled)
        .build();
S3AsyncClientBuilder builder =
    S3AsyncClient.builder()
        .httpClient(httpClient)
        .region(region)
        .credentialsProvider(credentialsProvider)
        .serviceConfiguration(serviceConfiguration)

However, for CRT-based client those settings are missing.

Use Case

It would be good if we can configure writeTimeout and specify max time for the request. I have not seen any other setting for that.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • [ ] I may be able to implement this feature request
  • [ ] This feature might incur a breaking change

AWS Java SDK version used

2.22.6

JDK version used

OpenJDK Runtime Environment Temurin-17.0.6+10 (build 17.0.6+10)

Operating System and version

MacOS Sonoma 14.2

abialas avatar Jan 02 '24 08:01 abialas