aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard

v2 missing setMetricCollector

Open miles-po opened this issue 3 years ago • 2 comments

Describe the bug

In v1 for Java, one could call AwsSdkMetrics.setMetricCollector(new MyCustomCollector()) if you wanted SDK client metrics but didn't want to use CloudWatch (we use Prometheus and Grafana). With a custom collector, we could automatically transform any AWS service call in the application to a Prometheus metric without having to wrap each and every call site or client reference in the codebase.

Expected Behavior

Single point to register and transform all AWS SDK metrics to custom output.

Current Behavior

No such equivalent API appears to exist in v2.

Reproduction Steps

Nothing in the JavaDocs or blog posts seem to show any alternatives. The bug is that v1 behavior cannot be reproduced.

Possible Solution

Re-implement a AwsSdkMetrics.setMetricCollector(...) equivalent for v2.

Additional Information/Context

No response

AWS Java SDK version used

2.17.220

JDK version used

17.0.1

Operating System and version

MacOS 12.2.1

miles-po avatar Jul 19 '22 20:07 miles-po

Hello @miles-po ,

Thank you very much for your submission. This feature is not currently supported on v2. I will relabel this as a feature request and bring it up to the team.

Best,

Yasmine

yasminetalby avatar Jul 20 '22 20:07 yasminetalby

Hello @miles-po ,

Update: The team has reviewed this feature request and has added it to the backlog.

Thank you again for your submission.

Best,

Yasmine

yasminetalby avatar Jul 25 '22 18:07 yasminetalby

Hi @yasminetalby @debora-ito, Is there any update to this issue? When can we expect for it to be implemented? Thanks, Karlo

kdelalic avatar Nov 01 '22 21:11 kdelalic

Hello @kdelalic ,

Thank you for your message.

This feature is in our backlog, but there is no current information available on the implementation timeline. You can add a 👍 to the original description if you want to showcase your interest in the feature, it helps us with prioritization of request. Something to note: Once a feature-request is implemented, we close the related issue submission so you will be notified since you have interacted with this issue.

Best regards,

Yasmine

yasminetalby avatar Nov 02 '22 00:11 yasminetalby

This would be super helpful for us too. Thanks!

frankjkelly avatar Jan 13 '23 14:01 frankjkelly