Re-use HttpResponseHandler headers

Open marcogrcr opened this issue 3 years ago • 1 comments

Re-use HttpResponseHandler constant header names instead of duplicating these values.

Motivation and Context

Don't repeat yourself.

Re-use HttpResponseHandler.X_AMZN_REQUEST_ID_HEADER in AwsXmlResponseTransformer instead of duplicating this header name.
Re-use HttpResponseHandler.X_AMZN_REQUEST_ID_HEADER_ALTERNATE in ExceptionTranslationInterceptor instead of duplicating this header name.
Re-use HttpResponseHandler.X_AMZ_ID_2_HEADER in AwsXmlErrorUnmarshaller instead of duplicating this header name.

Successful build of ./mvnw clean install -pl :aws-query-protocol -am

N/A

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Code maintainability (non-breaking change which makes code easier to maintain)

[X] I have read the CONTRIBUTING document
[X] Local run of mvn install succeeds
[X] My code follows the code style of this project
[ ] My change requires a change to the Javadoc documentation
[ ] I have updated the Javadoc documentation accordingly
[ ] I have added tests to cover my changes
[X] All new and existing tests passed
[ ] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
- [X] I have not added a changelog entry, because this change is completely internal and has negligible customer impact.
[ ] My change is to implement 1.11 parity feature and I have updated LaunchChangelog