aws-sdk-java-v2 icon indicating copy to clipboard operation
aws-sdk-java-v2 copied to clipboard

Implement retryable() method in exceptions.

Open marcogrcr opened this issue 3 years ago • 1 comments

Implement the retryable() method in the AwsServiceException and SdkServiceException classes.

Motivation and Context

The SDK internally has a way to determine whether an exception is retryable based on the status code and the error code. This change uses this existing logic to implement the retryable() method of the exception classes so that it no longer returns a static false value.

Modifications

Implement the retryable() method in the AwsServiceException and SdkServiceException classes.

Testing

Successful build of ./mvnw clean install -pl :aws-core -am in:

  • Amazon Linux 2: Linux 5.4.181-109.354.amzn2int.x86_64 #1 SMP Wed Mar 2 18:58:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
  • Java: openjdk version "1.8.0_332" | OpenJDK Runtime Environment (build 1.8.0_332-b08) | OpenJDK 64-Bit Server VM (build 25.332-b08, mixed mode)

Screenshots (if appropriate)

N/A

Types of changes

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

Checklist

  • [X] I have read the CONTRIBUTING document
  • [X] Local run of mvn install succeeds
  • [X] My code follows the code style of this project
  • [X] My change requires a change to the Javadoc documentation
  • [X] I have updated the Javadoc documentation accordingly
  • [X] I have added tests to cover my changes
  • [X] All new and existing tests passed
  • [X] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • [x] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [X] I confirm that this pull request can be released under the Apache 2 license

marcogrcr avatar May 18 '22 04:05 marcogrcr