aws-sam-cli icon indicating copy to clipboard operation
aws-sam-cli copied to clipboard

improving language of the templates change message

Open rjkerrison opened this issue 5 months ago • 2 comments

Which issue(s) does this change fix?

None.

Why is this change necessary?

"A change got detected" is non-standard English.

How does it address the issue?

It uses "has been" as the past perfect passive auxiliary verb form.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • [x] Add input/output type hints to new functions/methods
  • [x] Write design document if needed (Do I need to write a design document?)
  • [x] Write/update unit tests
  • [x] Write/update integration tests
  • [x] Write/update functional tests if needed
  • [x] make pr passes
  • [x] make update-reproducible-reqs if dependencies were changed
  • [x] Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rjkerrison avatar Aug 14 '25 13:08 rjkerrison

@rjkerrison , thank you for contributing. Looks like the make pr failed. Do you mind taking a look?

vicheey avatar Aug 15 '25 18:08 vicheey

@rjkerrison seems there's a linting error

make: *** [lint] Error 1
samcli/lib/providers/sam_function_provider.py:895:121: E501 Line too long (125 > 120)
    |
893 |     def _set_templates_changed(self, paths: List[str]) -> None:
894 |         LOG.info(
895 |             "A change has been detected in the templates %s. Marking templates as changed to be reloaded in the next invoke",
    |                                                                                                                         ^^^^^ E501
896 |             ", ".join(paths),
897 |         )
    |

Found 1 error.

please run make pr to fix, thank you for the PR!

seshubaws avatar Aug 19 '25 19:08 seshubaws