aws
Allow customisable AWS Request Context object to be passed on, or default to an object containing only the logger
Issue #, if available:
This PR allows a user to pass in a predefined Lambda Context object, either from the the CLI/--no-gui option or by adding one through the UI tool.
It adds a Manager to generate a sample Context object throught the UI.
If no context object is passed to the invocation it will use the pre-existing default that only providers a Logger to the invoced function.
The UI has been updated for both the 2.1 and 3.1 runtimes to allow a sample context to be generated.
I think this covers off https://github.com/aws/aws-lambda-dotnet/issues/665
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Thanks Norm I've updated the requested changes 👍
Not sure if you want me to resolve your queries, or if you'd prefer to do so after a re-review
Hey @normj Wondering if you've had a chance to recheck this, or if you have a time that you usually look at PR's?
Hi @normj I've fixed the merge conflicts and noticed I had missed readme docs - updated.
I think I've covered off all the requested changes, is there anything else I could do to help with this? Thanks
This is excellent @ryancormack and with support for RemainingTime would be exactly what I need.
@ryancormack @normj is there anything I can help with to get this PR (inc. RemainingTime) approved and merged?
@ryancormack Good afternoon. I was reviewing outstanding PR(s) and came across this feature request. Would it be possible for you to resolve conflicts and validate if the changes work in the latest code base? CCing @normj
I'll see if I can tidy it up 👍🏻. ~I seem to remember some complications around .NET3.1 and 6.0 support. Can 3.1 support be dropped?~ Edit: I see 2.1 support was dropped, and looking back through it, this was the version that had the complications.
Closing this here and re-opened in https://github.com/aws/aws-lambda-dotnet/pull/1470