aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

Add pip extra-index-url support with CodeArtifact login

Open nayaverdier opened this issue 5 years ago • 13 comments

Issue #, if available: Fixes #5409

Description of changes: Add --extra-index-url option to codeartifact login when used with --tool pip.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nayaverdier avatar Jul 26 '20 02:07 nayaverdier

Codecov Report

Merging #5411 into develop will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5411   +/-   ##
========================================
  Coverage    94.07%   94.07%           
========================================
  Files          190      190           
  Lines        14780    14788    +8     
========================================
+ Hits         13904    13912    +8     
  Misses         876      876           
Impacted Files Coverage Δ
awscli/customizations/codeartifact/login.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08e6cbe...7e4f981. Read the comment docs.

codecov-commenter avatar Jul 26 '20 02:07 codecov-commenter

This is blocking wide adoption of CodeArtifact in our organization, as we are required to store ONLY private packages on CodeArtifact and use the public PyPi directly for all others. Any plans to merge this?

roman-verbit-ai avatar Jul 31 '21 10:07 roman-verbit-ai

+1

shirahhoo avatar Dec 22 '21 12:12 shirahhoo

+1

david-goldb avatar Dec 22 '21 13:12 david-goldb

Can we get this merged and released?

arareko avatar Feb 16 '22 21:02 arareko

@justindho is there anything preventing this from being reviewed and merged? would love to use this flag

jeremyjordan avatar Aug 01 '22 20:08 jeremyjordan

Bump - would love to see this

ghandic avatar Jan 25 '23 02:01 ghandic

This would be super helpful in our organization, especially with existing CI/CD pipelines

benjaminreji avatar Mar 10 '23 08:03 benjaminreji

@kdaily @jonjara You left comments saying this would be reviewed soon™️ 3 years ago. Whats happening? Please address ASAP, this is so simple and highly requested.

jasondamour avatar Jul 01 '23 16:07 jasondamour

@nateprewit Sorry to ping, but I see that you can help with this :D

jasondamour avatar Jul 01 '23 16:07 jasondamour

Thank you for creating this PR and for your patience. The CLI team has raised the requested changes again with the CodeArtifact team as they are the owners of this customization. They let us know that this feature request is not being prioritized at this time. There is still some debate regarding design decisions related to the changes proposed here. We decided to set this PR to Draft pending further review and discussion. But in the meantime we encourage others to continue adding upvotes (:+1: s) and use cases to the corresponding tracking issue (https://github.com/aws/aws-cli/issues/5409).

tim-finnigan avatar Sep 14 '23 16:09 tim-finnigan

@tim-finnigan How is this outside of the jurisdiction of the CLI team? This change is purely to the CLI and how it sets up local client configuration. This doesn't change any auth flow

jasondamour avatar Sep 14 '23 19:09 jasondamour

@tim-finnigan How is this outside of the jurisdiction of the CLI team? This change is purely to the CLI and how it sets up local client configuration. This doesn't change any auth flow

The CodeArtifact team owns the maintenance of their customization and its usage within the CLI, similar to how other service teams maintain other CLI customizations. While the CLI team would need to do a final review and approval of any changes, it is ultimately up to the service team as to whether they plan to prioritize something involving the customization. I'll also note that for anyone who has a support plan, I recommend reaching out through AWS Support to highlight any pain points related to this or other customizations, as that can help provide data points which could better inform the prioritization.

tim-finnigan avatar Sep 14 '23 22:09 tim-finnigan