aws-cli icon indicating copy to clipboard operation
aws-cli copied to clipboard

Add --include --exclude to s3 ls

Open wingkwong opened this issue 6 years ago • 13 comments

Issue #, if available: #4832

Description of changes: Add --include --exclude to s3 ls

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

wingkwong avatar Feb 11 '20 09:02 wingkwong

Codecov Report

Merging #4941 (9080e12) into develop (97f2a09) will decrease coverage by 0.13%. The diff coverage is 30.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4941      +/-   ##
===========================================
- Coverage    92.63%   92.50%   -0.14%     
===========================================
  Files          196      196              
  Lines        15899    15926      +27     
===========================================
+ Hits         14728    14732       +4     
- Misses        1171     1194      +23     
Impacted Files Coverage Δ
awscli/customizations/s3/subcommands.py 93.01% <30.30%> (-4.20%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97f2a09...9080e12. Read the comment docs.

codecov-io avatar Feb 11 '20 09:02 codecov-io

Would love to see this merged!

christophertull avatar Jul 02 '20 21:07 christophertull

How can we get this feature merged, please?

pierrotevrard-dbit avatar Jan 14 '21 15:01 pierrotevrard-dbit

Can someone help review this PR please?

wingkwong avatar Mar 14 '21 13:03 wingkwong

Would love to see this!

RealDrewKlayman avatar Mar 30 '21 20:03 RealDrewKlayman

Would really like to see this feature going live. Are there any updates on this? 🤔

vladimirsvicevicsrb avatar Mar 24 '22 07:03 vladimirsvicevicsrb

Codecov Report

Merging #4941 (b616a94) into develop (cab1b4d) will decrease coverage by 0.13%. The diff coverage is 30.30%.

:exclamation: Current head b616a94 differs from pull request most recent head 71f5624. Consider uploading reports for the commit 71f5624 to get more accurate results

@@             Coverage Diff             @@
##           develop    #4941      +/-   ##
===========================================
- Coverage    92.63%   92.50%   -0.14%     
===========================================
  Files          203      203              
  Lines        16129    16156      +27     
===========================================
+ Hits         14941    14945       +4     
- Misses        1188     1211      +23     
Impacted Files Coverage Δ
awscli/customizations/s3/subcommands.py 93.01% <30.30%> (-4.20%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cab1b4d...71f5624. Read the comment docs.

codecov-commenter avatar Jul 17 '22 04:07 codecov-commenter

Almost there, would love to see that to !

tuanardouin avatar Oct 05 '22 14:10 tuanardouin

@TobiasDummschat last review in July was just about a duplicate title. Does that mean you could give a LGTM now and merge this?

andreineculau avatar Nov 09 '22 16:11 andreineculau

This would be nice to get in!

danielenricocahall avatar Dec 20 '22 13:12 danielenricocahall

@stealthycoin @TobiasDummschat It's been a while. Can help re-review?

wingkwong avatar Apr 07 '23 17:04 wingkwong

Hi all - I wanted to provide an update here. This was recently brought up to team discussion and we'll need to do further investigation on this. Though we can't share a definite timeline, we now have a backlog item for the team and will post further updates here. In the meantime, I'm going to convert this to draft.

aBurmeseDev avatar Sep 26 '23 22:09 aBurmeseDev