aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

refactor(imagebuilder-alpha): rename AwsManagedComponent/AwsManagedWorkflow to AmazonManagedComponent/AmazonManagedWorkflow, refactor ComponentData rendering

Open tarunb12 opened this issue 2 months ago • 2 comments

Issue

aws/aws-cdk-rfcs#789

Reason for this change

This change does some refactoring in Component/Workflow following comments from later PRs, such as aws/aws-cdk#36154.

Description of changes

  • Renames AwsManagedComponent to AmazonManagedComponent and moved to dedicated file
  • Renames AwsManagedWorkflow to AmazonManagedWorkflow and moved to dedicated file. Also adds distribute-image as a managed workflow which was missing.
  • Refactors ComponentData rendering - removing unnecessary isS3Reference public property in favor of rendering the properties we want injected into CfnComponent accordingly (this is similar to what is done for WorkflowData and ContainerRecipeData classes)

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Unit/integration testing (no differences in either except from class renaming)

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

tarunb12 avatar Dec 10 '25 23:12 tarunb12

TestsPassed ❌️SkippedFailed
Security Guardian Results
TestResult
No test annotations available

github-actions[bot] avatar Dec 10 '25 23:12 github-actions[bot]

TestsPassed ❌️SkippedFailed
Security Guardian Results with resolved templates
TestResult
No test annotations available

github-actions[bot] avatar Dec 10 '25 23:12 github-actions[bot]

@mergifyio update

ozelalisen avatar Dec 15 '25 14:12 ozelalisen

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codebuild-pr-build.yml without workflows permission

mergify[bot] avatar Dec 15 '25 14:12 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Dec 15 '25 14:12 mergify[bot]

Merge Queue Status

🚫 The pull request has left the queue (rule: default-squash) at 5cd58401ca9ec2dc629d946b05c4dc687d8a39b4

This pull request spent 4 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codebuild-pr-build.yml without workflows permission

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Dec 15 '25 14:12 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Dec 15 '25 15:12 mergify[bot]

Merge Queue Status

✅ The pull request has been merged at 05decdb7676907dcbc70d3e588b6dd1282274022

This pull request spent 35 minutes 32 seconds in the queue, including 31 minutes 57 seconds running CI. The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
    • [X] #36355
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • [X] #36355
  • [X] any of [🛡 GitHub branch protection]:
    • [X] check-success = validate-pr
    • [ ] check-neutral = validate-pr
    • [ ] check-skipped = validate-pr
  • [X] any of [🛡 GitHub branch protection]:
    • [X] check-success = build
    • [ ] check-neutral = build
    • [ ] check-skipped = build

mergify[bot] avatar Dec 15 '25 15:12 mergify[bot]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Dec 15 '25 16:12 mergify[bot]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] avatar Dec 15 '25 16:12 github-actions[bot]