refactor(imagebuilder-alpha): rename AwsManagedComponent/AwsManagedWorkflow to AmazonManagedComponent/AmazonManagedWorkflow, refactor ComponentData rendering
Issue
aws/aws-cdk-rfcs#789
Reason for this change
This change does some refactoring in Component/Workflow following comments from later PRs, such as aws/aws-cdk#36154.
Description of changes
- Renames AwsManagedComponent to AmazonManagedComponent and moved to dedicated file
- Renames AwsManagedWorkflow to AmazonManagedWorkflow and moved to dedicated file. Also adds
distribute-imageas a managed workflow which was missing. - Refactors ComponentData rendering - removing unnecessary
isS3Referencepublic property in favor of rendering the properties we want injected intoCfnComponentaccordingly (this is similar to what is done forWorkflowDataandContainerRecipeDataclasses)
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Unit/integration testing (no differences in either except from class renaming)
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
| Tests | Passed ❌️ | Skipped | Failed | |
|---|---|---|---|---|
| Security Guardian Results |
| Test | Result |
|---|---|
| No test annotations available | |
| Tests | Passed ❌️ | Skipped | Failed | |
|---|---|---|---|---|
| Security Guardian Results with resolved templates |
| Test | Result |
|---|---|
| No test annotations available | |
@mergifyio update
update
❌ Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codebuild-pr-build.yml without workflows permission
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Merge Queue Status
🚫 The pull request has left the queue (rule: default-squash) at 5cd58401ca9ec2dc629d946b05c4dc687d8a39b4
This pull request spent 4 seconds in the queue, with no time running CI.
Reason
The pull request can't be updated
For security reasons, Mergify can't update this pull request. Try updating locally. GitHub response: refusing to allow a GitHub App to create or update workflow
.github/workflows/codebuild-pr-build.ymlwithoutworkflowspermission
Hint
You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Merge Queue Status
✅ The pull request has been merged at 05decdb7676907dcbc70d3e588b6dd1282274022
This pull request spent 35 minutes 32 seconds in the queue, including 31 minutes 57 seconds running CI. The checks were run in-place.
Required conditions to merge
-
#approved-reviews-by >= 1[🛡 GitHub branch protection]- [X] #36355
-
#changes-requested-reviews-by = 0[🛡 GitHub branch protection]- [X] #36355
- [X] any of [🛡 GitHub branch protection]:
- [X]
check-success = validate-pr - [ ]
check-neutral = validate-pr - [ ]
check-skipped = validate-pr
- [X]
- [X] any of [🛡 GitHub branch protection]:
- [X]
check-success = build - [ ]
check-neutral = build - [ ]
check-skipped = build
- [X]
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.