feat(cloudwatch): add option to show labels on pie chart
Issue # (if applicable)
Closes #28929
Reason for this change
Cloudwatch Dashboard console has this option but cdk GraphWidget does not
Description of changes
- adds a new optional boolean parameter to
GraphWidgetPropscalleddisplayLabelsOnChart- naming obtained from description of the option in the AWS Console
- updates aws-cloudwatch README.md with sample usage
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Created new unit and integration test and ran them
Checklist
- [x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: b120954a861fa8f9b3e0ee7d812ae00431f85d1b
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Hi @Kasra-G , just checking if you need any further feedback/support to update this PR.
Thanks for the check-in. Haven't had a chance to make the changes yet, I do intend on getting that done before the PR gets marked stale
Not sure why request-cli-integ-test is failing, I simply squashed, rebased to tip of mainline, and force pushed. I suppose I could look through my reflog and force push back to the previous version.
Edit: Force pushed back to the previous version and I guess the check is still failing. Not sure what I can do, my guess is that the check itself is broken given I see several other open PRs with the same error
@vishaalmehrishi I have made the appropriate changes but for some reason the PR code build is not rerunning and I am getting some file not found error in the request-cli-integ-test/cli-changes workflow, even when I pushed the commit you previously reviewed which had no workflow issues prior. Not sure how I can resolve that.
I noticed my other PR is also not running the PR code build, did that change recently?
Seems the issue might be that pr code build only runs for branches targeting v2-release. Any reason why we wouldn't want these builds running for pull requests targeting main?
https://github.com/aws/aws-cdk/blob/main/.github/workflows/codebuild-pr-build.yml#L12-L13
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
This pull request has been removed from the queue for the following reason: checks failed.
The merge conditions cannot be satisfied due to failing checks:
You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
@MergifyIO requeue
requeue
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.