aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

feat(codepipeline): `executionMode` property for Pipeline

Open go-to-k opened this issue 2 years ago • 1 comments

Issue # (if applicable)

Closes #29147.

Reason for this change

We would be good to add a new parameter for execution mode.

see:

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codepipeline-pipeline.html#cfn-codepipeline-pipeline-executionmode

https://aws.amazon.com/about-aws/whats-new/2024/02/codepipeline-trigger-filters-execution-modes

Description of changes

Add an executionMode parameter to the PipelineProps interface.

Description of how you validated changes

Both unit and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

go-to-k avatar Feb 17 '24 15:02 go-to-k

@jumic

Thanks for your review. I modified them, could you please check? (The format of line breaks, etc. has been slightly changed.)

go-to-k avatar Mar 03 '24 08:03 go-to-k

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Mar 07 '24 19:03 mergify[bot]

@gracelu0

Thanks for your approval. The merge of the main branch caused a difference in the integ test snapshot, so I modified the snapshot again. Could you please approve it again?

  CHANGED    aws-codepipeline-actions/test/integ.pipeline-type-v2 3.224s
      Resources
[~] AWS::Lambda::Function CustomS3AutoDeleteObjectsCustomResourceProviderHandler9D90184F 
 └─ [~] Code
     └─ [~] .S3Key:
         ├─ [-] 2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3.zip
         └─ [+] 54e6f07bf3aea46d100719f3b21fe0fb45ae789ee372d42d8cdfb97e21aba96c.zip

go-to-k avatar Mar 08 '24 07:03 go-to-k

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Mar 08 '24 19:03 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c1fcdba52e4b6d34e0eb236779bd8b182e618d95
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Mar 08 '24 20:03 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Mar 08 '24 20:03 mergify[bot]