amazon-ssm-agent icon indicating copy to clipboard operation
amazon-ssm-agent copied to clipboard

[Bug] SSM Agent can not be installed on Windows with $PSCulture = "de-DE"

Open qoomon opened this issue 1 year ago • 3 comments

Because of checking against the output of windows service manager, following checks will not match and therfore start and stop will always fail.

https://github.com/aws/amazon-ssm-agent/blob/f6ab6700a1d3ffe69ae759cfca759fb28d444218/agent/setupcli/managers/servicemanagers/windowsmanager.go#L51

https://github.com/aws/amazon-ssm-agent/blob/f6ab6700a1d3ffe69ae759cfca759fb28d444218/agent/setupcli/managers/servicemanagers/windowsmanager.go#L72

qoomon avatar Dec 06 '24 12:12 qoomon

I think the error code to check should be 2 in both cases

https://github.com/aws/amazon-ssm-agent/blob/f6ab6700a1d3ffe69ae759cfca759fb28d444218/agent/setupcli/managers/servicemanagers/windowsmanager.go#L67

https://github.com/aws/amazon-ssm-agent/blob/f6ab6700a1d3ffe69ae759cfca759fb28d444218/agent/setupcli/managers/servicemanagers/windowsmanager.go#L46

qoomon avatar Dec 06 '24 15:12 qoomon

Thanks, we will look into fixing this.

Aperocky avatar Jan 19 '25 19:01 Aperocky

that is still an issue. Are you gonna fix it or merge me PR any time soon?

qoomon avatar Mar 08 '25 19:03 qoomon

A fix for this will be available with the coming release. Thank you for bringing this up to our attention.

drmihalj avatar Mar 28 '25 18:03 drmihalj

@drmihalj why you've closed this issue? cant see any commit nor merge of my PR https://github.com/aws/amazon-ssm-agent/issues/604#issuecomment-2762122457

qoomon avatar Apr 07 '25 11:04 qoomon

@drmihalj

A fix for this will be available with the coming release.

what's the striven release date?

We desperately need this to be fixed for a customer project on Friday!

qoomon avatar Apr 07 '25 11:04 qoomon