amazon-cloudwatch-agent icon indicating copy to clipboard operation
amazon-cloudwatch-agent copied to clipboard

Clean Internal Pipeline SSM Parameter Older Than 14 Days.

Open sethAmazon opened this issue 3 years ago • 6 comments

Description of the issue

We have 10k ssm param

Description of changes

Delete ssm param over 2 months old in us-west-2

Tests

https://github.com/aws/amazon-cloudwatch-agent/actions/runs/3185074152/jobs/5194217790

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make linter

sethAmazon avatar Oct 04 '22 20:10 sethAmazon

Codecov Report

Merging #605 (967be58) into master (5f5b142) will decrease coverage by 0.24%. The diff coverage is n/a.

:exclamation: Current head 967be58 differs from pull request most recent head 67eb181. Consider uploading reports for the commit 67eb181 to get more accurate results

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   56.87%   56.63%   -0.25%     
==========================================
  Files         374      375       +1     
  Lines       17743    17838      +95     
==========================================
+ Hits        10092    10102      +10     
- Misses       7061     7145      +84     
- Partials      590      591       +1     
Impacted Files Coverage Δ
translator/cmdutil/userutil_darwin.go 10.52% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 04 '22 20:10 codecov-commenter

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Oct 20 '22 00:10 github-actions[bot]

Have we considered attaching an expiration policy at the time of creation? That way we dont have the throttling issue and dont need to manage cleanup ourselves.

sky333999 avatar Oct 25 '22 14:10 sky333999

Have we considered attaching an expiration policy at the time of creation?

Agreed. That being said, I don't see why we can't have both. Idk which is easier to incorporate but since we're already most of the way there with this PR, might as well use this as a failsafe for things that fall through the cracks for the expiration policy

SaxyPandaBear avatar Oct 25 '22 17:10 SaxyPandaBear

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Nov 02 '22 00:11 github-actions[bot]

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Apr 23 '23 00:04 github-actions[bot]