Drop Support for ADOT Collector
Description of the issue
Drop support for ADOT Collector
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Have not tested yet
Requirements
Before commit the code, please do the following steps.
- Run
make fmtandmake fmt-sh - Run
make linter
This PR was marked stale due to lack of activity.
Codecov Report
Merging #522 (b855993) into master (4cefc9f) will decrease coverage by
0.24%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
- Coverage 56.87% 56.62% -0.25%
==========================================
Files 374 375 +1
Lines 17744 17839 +95
==========================================
+ Hits 10092 10102 +10
- Misses 7062 7146 +84
- Partials 590 591 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| translator/cmdutil/userutil_darwin.go | 10.52% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Will on hold the merge until the final decision has been made .
This PR was marked stale due to lack of activity.
- It's been over a month since the PR was first opened. Can you confirm that this still works as expected and provide evidence on Windows and Linux, minimum, MacOS if possible? Windows validation
Linux validation
Mac Validation
![]()
I think what we should do eventually as a follow up is remove the statuses for CWOC in the control script, but probably don't need to do that right now.
I think what we should do eventually as a follow up is remove the statuses for CWOC in the control script, but probably don't need to do that right now.
Hmm I removed that and remove some sanity check relates to that status but I guess we have decided in other way in QS.
Linux validation
Mac Validation