amazon-cloudwatch-agent icon indicating copy to clipboard operation
amazon-cloudwatch-agent copied to clipboard

Drop Support for ADOT Collector

Open khanhntd opened this issue 3 years ago • 2 comments

Description of the issue

Drop support for ADOT Collector

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Have not tested yet

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make linter

khanhntd avatar Jul 26 '22 12:07 khanhntd

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Aug 03 '22 00:08 github-actions[bot]

Codecov Report

Merging #522 (b855993) into master (4cefc9f) will decrease coverage by 0.24%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
- Coverage   56.87%   56.62%   -0.25%     
==========================================
  Files         374      375       +1     
  Lines       17744    17839      +95     
==========================================
+ Hits        10092    10102      +10     
- Misses       7062     7146      +84     
- Partials      590      591       +1     
Impacted Files Coverage Δ
translator/cmdutil/userutil_darwin.go 10.52% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 15 '22 20:08 codecov-commenter

Will on hold the merge until the final decision has been made .

khanhntd avatar Aug 16 '22 18:08 khanhntd

This PR was marked stale due to lack of activity.

github-actions[bot] avatar Aug 24 '22 00:08 github-actions[bot]

  1. It's been over a month since the PR was first opened. Can you confirm that this still works as expected and provide evidence on Windows and Linux, minimum, MacOS if possible? Windows validation image Linux validation image Mac Validation image

ymtaye avatar Sep 01 '22 17:09 ymtaye

I think what we should do eventually as a follow up is remove the statuses for CWOC in the control script, but probably don't need to do that right now.

SaxyPandaBear avatar Sep 01 '22 19:09 SaxyPandaBear

I think what we should do eventually as a follow up is remove the statuses for CWOC in the control script, but probably don't need to do that right now.

Hmm I removed that and remove some sanity check relates to that status but I guess we have decided in other way in QS.

khanhntd avatar Sep 01 '22 19:09 khanhntd