amazon-cloudwatch-agent icon indicating copy to clipboard operation
amazon-cloudwatch-agent copied to clipboard

[Pending discussion] Fail translate if "System", "Memory", "TCPv4", "TCPv6" has resources defined.

Open sethAmazon opened this issue 4 years ago • 1 comments

Current windows metrics behavior : 1.If no resource field specified, apply "------" to comply with windows_perf_counters 2. However, for objectName ["System", "Memory", "TCPv4", "TCPv6"], we override resources field with "------" no matter what they specified.

Desired behavior proposed: 1.If no resource field specified, apply "------" to comply with windows_perf_counters 2. Let translator emit log notify customer what objectName is configured with "no instance" option "-----" is not a user friendly log). Translator will also fail translation if any resources field provided for ["System", "Memory", "TCPv4", "TCPv6"].

Pros:

Consistent behavior for all windows metrics. if customer using ["System", "Memory", "TCPv4", "TCPv6" ], and specify instance using "*" or something else, we don't want eliminate their metric silently There is no customer impact right now. We can treat this as low priority.

https://github.com/aws/amazon-cloudwatch-agent/blob/master/translator/translate/metrics/config/registered_instances.go#L12

sethAmazon avatar Jun 14 '21 19:06 sethAmazon

This issue was marked stale due to lack of activity.

github-actions[bot] avatar Oct 06 '21 00:10 github-actions[bot]