serverless-image-handler icon indicating copy to clipboard operation
serverless-image-handler copied to clipboard

Add test case to verify utf8 support in object key

Open StaymanHou opened this issue 4 years ago • 7 comments

Follow-up PR for a previous PR https://github.com/aws-solutions/serverless-image-handler/pull/311 that's already resolved.

Add test case to verify it works now with object keys containing utf8 characters.

StaymanHou avatar Dec 28 '21 21:12 StaymanHou

Thank you for the PR. I have added this to our backlog queue.

fisenkodv avatar Jan 03 '22 13:01 fisenkodv

This pr has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

github-actions[bot] avatar Dec 21 '22 00:12 github-actions[bot]

This pr was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Dec 28 '22 00:12 github-actions[bot]

This is still on our backlog to evaluate, and we will get to it. We appreciate your effort and submission.

dougtoppin avatar Dec 28 '22 01:12 dougtoppin

This pr has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

github-actions[bot] avatar Mar 29 '23 00:03 github-actions[bot]

Hi @StaymanHou,

Thanks for your patience here, the change has been made internally and is set to be included in the next release. While our internal processes had us merge the code manually, once the release with this change is out, you'll see yourself included in the external contributors section towards the bottom of the readme and this PR will be closed.

Thanks for your contributions to Serverless Image Handler :) Simon

simonkrol avatar Feb 16 '24 16:02 simonkrol

Awesome! Thx for reviewing and merging the PR.

StaymanHou avatar Feb 17 '24 18:02 StaymanHou

Test case was included in v6.2.6, thanks for your contributions.

simonkrol avatar Jun 27 '24 20:06 simonkrol