serverless-patterns icon indicating copy to clipboard operation
serverless-patterns copied to clipboard

S3 to S3 Replication in SAM

Open jorgetovar opened this issue 2 years ago • 7 comments

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jorgetovar avatar Jan 22 '24 21:01 jorgetovar

Hi @jorgetovar , thanks for the pull request. However, your submission does not represent a serverless pattern as we see it. Those are typically intended to be primarily IaC-focused implementations of 2-4 AWS services. Feel free to expand upon this and resubmit then.

bfreiberg avatar Jan 24 '24 08:01 bfreiberg

But I see a similar pattern here but with CDK

https://serverlessland.com/patterns/s3-s3-cdk

jorgetovar avatar Jan 25 '24 18:01 jorgetovar

Thanks for your feedback. We've discussed it and will accept this pattern, also given the pattern you referenced. I'll review your submission soon.

bfreiberg avatar Jan 31 '24 10:01 bfreiberg

@jorgetovar , do you still plan to work on this issue?

bfreiberg avatar Feb 28 '24 18:02 bfreiberg

@bfreiberg

Please let me know if there are any specific areas you'd like me to address or if you need any further information from my end.

Thank you for your time and good advice

jorgetovar avatar Mar 06 '24 13:03 jorgetovar

Looks good in general. I've highlighted a few minor adjustments

bfreiberg avatar Mar 18 '24 16:03 bfreiberg

@bfreiberg

Please let me know if there are anything else to address or if you need any further information from my end.

jorgetovar avatar Mar 27 '24 20:03 jorgetovar

Looks good in general. I've highlighted a few minor adjustments

Looking forward to see if it's anything else missing. And thanks for all the assistance

jorgetovar avatar Apr 04 '24 03:04 jorgetovar

Looks pretty good, thanks for the updates. I highlighted two minor changes. It would be great if you could address them

bfreiberg avatar Apr 04 '24 12:04 bfreiberg

I will work on that today

jorgetovar avatar Apr 24 '24 11:04 jorgetovar