pcluster-manager icon indicating copy to clipboard operation
pcluster-manager copied to clipboard

Fix storage removal

Open mtfranchetto opened this issue 3 years ago • 0 comments

Description

Fixes #286

Changes

Move from object to array for UI settings of a storage ("Use existing" toggle) to keep the storage config and the UI settings in sync (both use arrays now)

Changelog entry

Fix removing a shared storage

How Has This Been Tested?

  • added 2-3 storages
  • removed each of them in random order
  • repeated the process a couple times

PR Quality Checklist

  • [x] I added tests to new or existing code
  • [ ] I removed hardcoded strings and used our i18n solution instead (see here)
  • [x] I checked that npm run build builds without any error
  • [x] I checked that clusters are listed correctly
  • [x] I checked that a new cluster can be created (config is produced and dry run passes)
  • [x] I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mtfranchetto avatar Sep 02 '22 12:09 mtfranchetto