data-lake-as-code icon indicating copy to clipboard operation
data-lake-as-code copied to clipboard

updating Roda template synth script and fixing rds.DatabaseInstanceProps credentials prop

Open arozar opened this issue 5 years ago • 0 comments

Commit 1 - updating Roda table and database names for template synth script

Description of changes: The file SynthRodaTemplates.sh has incorrect naming of glue tables and database names that are created using the Cloudformation stacks that are suggested in comments at the bottom of the script.

Commit 2 - updating rds.DatabaseInstanceSourceProps to use credentials object

Description of changes: Currently, the Typescript is no longer compiling.

This is due to the fact the rds.DatabaseInstanceProps interface now uses a credentials property rather than a username and password properties.

Have tested by doing the following:

  • Code now compiles
  • Deployed the environment and the SSM run command scripts are now able to use the dbSecrets to seed data in the RDS instances.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

arozar avatar Jan 18 '21 17:01 arozar