powertools-lambda-python icon indicating copy to clipboard operation
powertools-lambda-python copied to clipboard

Tech debt: Review the name of the method extract_data_from_envelope in JMESPath Functions

Open leandrodamascena opened this issue 1 year ago • 1 comments

Why is this needed?

The extract_data_from_envelope method name seems strange for customers to understand what it is for. We now have the opportunity to deprecate this method, add a warning, and create a new one.

Which area does this relate to?

JMESPath functions

Suggestion

Deprectaed this method.

Acknowledgment

leandrodamascena avatar Apr 26 '24 11:04 leandrodamascena

We just added this method in the TypeScript repo a few weeks ago.

Do we have any anecdotes for deprecating this and how we can improve?

I'm not necessarily challenging the idea, I'm more interested in how we can disambiguate it and make it clearer.

dreamorosi avatar May 07 '24 09:05 dreamorosi

Hello @dreamorosi! I don't have enough anecdotes about this. @heitorlessa may have more context about the reasons behind this change and any customer feedback received. Regardless, we do not plan to remove this method entirely. Instead, we will add a deprecation warning and remove it in the V4 release. As for the new method name, we believe query would be a good name, as it better conveys the idea of retrieving data, and the query name is more commonly used across similar concepts of data querying.

leandrodamascena avatar May 31 '24 10:05 leandrodamascena

Closed via #4907

leandrodamascena avatar Aug 07 '24 18:08 leandrodamascena

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Aug 07 '24 18:08 github-actions[bot]