powertools-lambda-java icon indicating copy to clipboard operation
powertools-lambda-java copied to clipboard

Maintenance: V2 updates - review interface & propose improvements for Tracing module

Open scottgerring opened this issue 2 years ago • 3 comments

Summary

We should use the V2 release as an opportunity to reflect upon the interfaces of our existing modules and identify areas of improvement. This work has been done as part of rewrites for some modules, and in isolation for others - check out #1283 for details.

Why is this needed?

  • Minimize the likelihood that we need to make more breaking changes to PT-Java again soon in the future
  • Double-down on the quality of the project by forcing large-scale code review
  • Increase knowledge of the modules around the contributor team

Which area does this relate to?

No response

Solution

  1. A review of the current module, its public interface and structure, and potential areas for improvement documented on this ticket for discussion
  2. A draft PR against the v2 branch showing the high level impact of proposed changes
  3. PR completed and merged into v2

Acknowledgment

scottgerring avatar Oct 10 '23 12:10 scottgerring

Happy to take a look at this!

AlexeySoshin avatar Nov 22 '23 13:11 AlexeySoshin

@heitorlessa - what do you think about this - do you have a view on whether or not all languages should be going modular with regards to the tracing providers like python has?

scottgerring avatar Dec 15 '23 12:12 scottgerring

I noticed that the way we are including tracing at the moment pulls in bits of the V1 AWS SDK. We should definitely fix that while we are here.

scottgerring avatar Feb 22 '24 11:02 scottgerring

The Tracing module will not receive any major updates as part of v2. I fixed all vulnerabilities related to AWS SDK v1 but it is a transitive dependency of X-RAY. https://github.com/aws-powertools/powertools-lambda-java/commit/699eb0e3af33062bd6e7e15fffa2a4907b2e4b85

X-RAY has not announced any plan going forward yet which means that we cannot do any changes related to that prior to the v2 release. Potentially a refactoring will be needed for v3. This should be justified by becoming more open to different tracing providers.

phipag avatar Jun 06 '25 12:06 phipag