cloudformation-cli icon indicating copy to clipboard operation
cloudformation-cli copied to clipboard

Project should use modern python packaging techniques

Open FollowTheProcess opened this issue 1 year ago • 0 comments

Hello 👋🏻

I notice this repo still uses setup.py and has some potentially outdated config for modern python packaging. As far as I can tell it should be pretty easy to port to pyproject.toml using PEP621 and using the new PEP517 and PEP518 standards. There are no C extensions to build for instance.

In addition, the project might benefit from some of the more modern python toolset i.e.:

  • Ruff for linting over pylint
  • Introducing gradual typing with e.g. MyPy
  • A modern package manager such as pdm or poetry

I'd be happy to submit a PR implementing some or all of the above depending on what you do/don't want to be included. I'd suggest the move to storing metadata in pyproject.toml and using the new packaging/build techniques as a minimum

Thanks!

FollowTheProcess avatar Jul 25 '24 13:07 FollowTheProcess