aws-cloudformation
bugfix: missing classtransformer upgrade and proper model types
Issue ARCH-1058
Description of changes:
Updating the template for the model to conform to the new type coming from class transformer as well as the codegen and package.json templates to match the new versions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@kddejong Heyo, just packaged the python part and tested it and all good. Looks like the unit test issue is on the loggerproxy.
I can't replicate it on my end, but I'm using an M3
@HeatherFlux there is one more fix you will need for the macOS builds in that PR. Then I can close my PR
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.97%. Comparing base (
115b7c0) to head (b3e34be). Report is 2 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 98.47% 97.97% -0.51%
==========================================
Files 14 14
Lines 1249 1281 +32
Branches 213 244 +31
==========================================
+ Hits 1230 1255 +25
- Misses 17 24 +7
Partials 2 2
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 97.97% <100.00%> (-0.51%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
I've just updated @amazon-web-services-cloudformation/cloudformation-cli-typescript-lib to v1.0.6 and witnessed this issue. Do we know if the repository is still active? What's the best way to get this merged and a new version released? For now, I've pinned to v1.0.5 and configured Dependabot to ignore this dependency.
I reverted the colima change that @kddejong had put in. If this gets merged it will fix the plugin for all TS developers
I've just updated
@amazon-web-services-cloudformation/cloudformation-cli-typescript-libto v1.0.6 and witnessed this issue. Do we know if the repository is still active? What's the best way to get this merged and a new version released? For now, I've pinned to v1.0.5 and configured Dependabot to ignore this dependency.
Last time I had to ping our AWS TAM to get some movement. You might want to ping your TAM as well.
@ericzbeard Looks like all the CI's are deprecated :edit the ones that are not deprecated did pass however.
