feat(amplify-category-auth): add HostedUI custom domain in metadata
Fix #1880
HostedUIDomain equals to either the domain prefix or the custom domain defined in the user pool. However we need to differentiate a custom domain from a domain prefix for the config put in aws-exports.js
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Codecov Report
Merging #6499 (a21f00e) into master (39dfd27) will not change coverage. The diff coverage is
0.00%.
@@ Coverage Diff @@
## master #6499 +/- ##
========================================
Coverage 57.28% 57.28%
========================================
Files 479 479
Lines 21695 21695
Branches 4096 4312 +216
========================================
Hits 12429 12429
+ Misses 8405 8385 -20
- Partials 861 881 +20
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...c/provider-utils/awscloudformation/import/index.ts | 5.08% <ø> (ø) |
|
| ...mplify-frontend-ios/lib/frontend-config-creator.js | 16.66% <0.00%> (ø) |
|
| packages/amplify-util-mock/src/api/api.ts | 0.00% <0.00%> (ø) |
|
| packages/graphql-mapping-template/src/print.ts | 35.29% <0.00%> (ø) |
|
| packages/amplify-util-mock/src/storage/storage.ts | 0.00% <0.00%> (ø) |
|
| ...ges/amplify-util-mock/src/CFNParser/stack/index.ts | 0.00% <0.00%> (ø) |
|
| ...es/amplify-util-mock/src/api/resolver-overrides.ts | 0.00% <0.00%> (ø) |
|
| ...es/graphql-transformer-core/src/stripDirectives.ts | 35.29% <0.00%> (ø) |
|
| .../amplify-cli-core/src/state-manager/pathManager.ts | 67.44% <0.00%> (ø) |
|
| .../amplify-util-mock/src/utils/lambda/loadMinimal.ts | 0.00% <0.00%> (ø) |
|
| ... and 11 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 39dfd27...a21f00e. Read the comment docs.
Any ETA on when this can be merged? This would be great and it looks like the work is already done...
bump?
@edwardfoyle any news on this ?
Hey @vic-blt, would you be interested in continuing to work on this PR? If so, please rebase this onto dev by running git rebase dev. We will help you with getting this PR to the finish line 🏁
Codecov Report
:x: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.58%. Comparing base (ec9a2ba) to head (d1ac574).
:warning: Report is 715 commits behind head on dev.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...ider-awscloudformation/src/display-helpful-urls.ts | 0.00% | 5 Missing :warning: |
| ...mplify-frontend-ios/lib/frontend-config-creator.js | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## dev #6499 +/- ##
===========================================
+ Coverage 0.00% 47.58% +47.58%
===========================================
Files 1296 843 -453
Lines 149743 38370 -111373
Branches 1296 7852 +6556
===========================================
+ Hits 0 18257 +18257
+ Misses 148447 18481 -129966
- Partials 1296 1632 +336
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@evcodes I rebased onto dev.
Thank you, I am running the changes through our e2e test suite
@evcodes @goldbez When do you plan to merge this RP? This RP change only supports AMPLIFY auth import. If this RP is merged, I would willing to create an RP that adds support for custom domains via amplify auth add/amplify auth update.