amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

fix(amplify-category-notifications): fix email channel removal

Open UnleashedMind opened this issue 5 years ago • 2 comments

fix #5848

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

UnleashedMind avatar Dec 01 '20 21:12 UnleashedMind

Codecov Report

Merging #6030 (7b942fc) into master (db9bf58) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6030    +/-   ##
========================================
  Coverage   58.21%   58.21%            
========================================
  Files         440      440            
  Lines       20160    20160            
  Branches     3988     3782   -206     
========================================
  Hits        11736    11736            
- Misses       7609     7629    +20     
+ Partials      815      795    -20     
Impacted Files Coverage Δ
...mplify-category-notifications/lib/channel-Email.js 0.00% <ø> (ø)
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 67.85% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
...graphql-transformer-core/src/TransformerContext.ts 25.09% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db9bf58...7b942fc. Read the comment docs.

codecov[bot] avatar Dec 01 '20 22:12 codecov[bot]

@UnleashedMind I'd like to run the test suite on this, but do you mind rebasing on dev first? Thanks!

danielleadams avatar Jul 25 '22 16:07 danielleadams

Closing due to inactivity.

danielleadams avatar Oct 17 '22 22:10 danielleadams