amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

chore: ask for consent for diagnose report

Open aws-eddy opened this issue 2 years ago • 1 comments

Description of changes

Previously the CLI would ask permission for diagnose command on init but this PR moves the ask to the beginning of diagnose command. This is set on a per-project basis.

Issue #, if available

Description of how you validated changes

Checklist

  • [x] PR description included
  • [x] yarn test passes
  • [x] Tests are changed or added
  • [ ] Relevant documentation is changed or added (and PR referenced)
  • [ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • [ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws-eddy avatar May 31 '23 21:05 aws-eddy

E2E tests:

  • https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22340
    • Failed
      • src/tests/init_f.test.ts https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22340/workflows/a1534b4b-5fef-4b88-ac3b-17e3de85ea2f/jobs/1033398
      • src/tests/migration_tests_v12/auth.migration.test.ts https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22340/workflows/a1534b4b-5fef-4b88-ac3b-17e3de85ea2f/jobs/1033374
      • src/tests/hosting.test.ts https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22340/workflows/a1534b4b-5fef-4b88-ac3b-17e3de85ea2f/jobs/1033380
      • src/tests/hostingPROD.test.ts https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22340/workflows/a1534b4b-5fef-4b88-ac3b-17e3de85ea2f/jobs/1033384
      • src/tests/auth_6.test.ts https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22340/workflows/a1534b4b-5fef-4b88-ac3b-17e3de85ea2f/jobs/1033373
    • Re-run: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22340/workflows/06f2fd77-4270-42eb-ab4d-bcd21810c979
  • https://tiny.amazon.com/ajwhuog4/IsenLink

0618 avatar Jul 25 '23 03:07 0618