amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard
verified publisher icon aws-amplify

feat: pretty print cloudformation event logs

Open sreekanth-sreekumar opened this issue 3 years ago • 35 comments

Description of changes

This pull request deals with the pretty print of the cloud formation event logs triggered during deployment of resources in an amplify project.

Issue #, if available

Description of how you validated changes

Checklist

  • [x] PR description included
  • [x] yarn test passes
  • [x] Tests are changed or added
  • [x] Relevant documentation is changed or added (and PR referenced)
  • [x] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sreekanth-sreekumar avatar Jul 08 '22 02:07 sreekanth-sreekumar

This pull request introduces 4 alerts and fixes 1 when merging 7fab006b0f974038f0b0e48c10f3c797d24d2514 into a1896480a5618a1b3426b50ed7e2b7cd47bce52f - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 08 '22 02:07 lgtm-com[bot]

This pull request introduces 3 alerts and fixes 1 when merging 1eebafa4ff6b2ad0ed657804247d881640acdddc into a1896480a5618a1b3426b50ed7e2b7cd47bce52f - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 08 '22 17:07 lgtm-com[bot]

This pull request introduces 3 alerts and fixes 1 when merging 615c42aa45b63587ff4a9b444a7e36658163490e into a1896480a5618a1b3426b50ed7e2b7cd47bce52f - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 08 '22 18:07 lgtm-com[bot]

This pull request introduces 3 alerts and fixes 1 when merging d36745caf6399dd3267c3d6f2585ba822d8ed14c into c9651b900a906821a067ea4054159b639d8262b2 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 08 '22 22:07 lgtm-com[bot]

This pull request introduces 3 alerts and fixes 1 when merging 854c9a22ec38ce69ed599b30874fe2cb06b84cb7 into 8cbbd60cb88cd68765273b92fb48b0649a2a0b34 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 11 '22 17:07 lgtm-com[bot]

This pull request introduces 3 alerts and fixes 1 when merging fe6624acb337324d0bf635effb4da84565c80a2e into 8cbbd60cb88cd68765273b92fb48b0649a2a0b34 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 11 '22 17:07 lgtm-com[bot]

This pull request introduces 3 alerts and fixes 1 when merging d9b51aebb5eeb3d360c85fd78bcdfcd975d128ee into ddf4b556e8bb85b65b580674951926e8b72c343f - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 11 '22 18:07 lgtm-com[bot]

2 for Unused variable, import, function or class 1 for Useless assignment to local variable

Can you address these too?

ammarkarachi avatar Jul 11 '22 18:07 ammarkarachi

I have addressed as much as I can now. The only thing I have not removed is a function that was used to display an earlier error message. Even though it's not used right now, it could potential references in the future.

sreekanth-sreekumar avatar Jul 11 '22 19:07 sreekanth-sreekumar

This pull request introduces 1 alert and fixes 1 when merging 830f2b7176dd69940c758ee9fbdbf2f609c7c16f into ddf4b556e8bb85b65b580674951926e8b72c343f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 11 '22 19:07 lgtm-com[bot]

This pull request introduces 1 alert and fixes 1 when merging b16cdf5988a2c45aa2e7030fe9b43d9b5798ef69 into ddf4b556e8bb85b65b580674951926e8b72c343f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 11 '22 23:07 lgtm-com[bot]

This pull request introduces 1 alert and fixes 1 when merging 0dcbb32ee882391dbc14b873d3e95a7b5cf85266 into 4a650d8bbb43c8a5cc155a9c8582e2b64c537a7b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 12 '22 16:07 lgtm-com[bot]

This pull request introduces 10 alerts and fixes 1 when merging ea10874bf5d37f73fac91b12cbb23c3e4e284fa7 into ea6827ad37a167876608eb4fe717c1e52db56309 - view on LGTM.com

new alerts:

  • 9 for Property access on null or undefined
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 23 '22 00:07 lgtm-com[bot]

This pull request introduces 10 alerts and fixes 1 when merging 8baaf2aef2151186e6599bf2ff51f1eafce2e91c into 0273dc045218b11e69da36af147d679fdf03a545 - view on LGTM.com

new alerts:

  • 9 for Property access on null or undefined
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 25 '22 17:07 lgtm-com[bot]

Ready for another review. @jhockett and @edwardfoyle

sreekanth-sreekumar avatar Jul 25 '22 18:07 sreekanth-sreekumar

This pull request introduces 10 alerts and fixes 1 when merging c67f8874cf64310d2cd423603859e81ba4ea2ac0 into 23bf15d3ff33a5a7101f2116460620a231c744f5 - view on LGTM.com

new alerts:

  • 9 for Property access on null or undefined
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 25 '22 18:07 lgtm-com[bot]

This pull request introduces 10 alerts and fixes 1 when merging ea6422365fdd8277dafa3b6f82ac921d55e4f75c into 23bf15d3ff33a5a7101f2116460620a231c744f5 - view on LGTM.com

new alerts:

  • 9 for Property access on null or undefined
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 25 '22 20:07 lgtm-com[bot]

This pull request introduces 14 alerts and fixes 1 when merging 34427245193b19637f5dd9d767d6074b156615ef into 23bf15d3ff33a5a7101f2116460620a231c744f5 - view on LGTM.com

new alerts:

  • 9 for Property access on null or undefined
  • 5 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 26 '22 16:07 lgtm-com[bot]

This pull request introduces 14 alerts and fixes 1 when merging 2fedd289c217081fc39478b51348b2f4e1ef1d5f into 23bf15d3ff33a5a7101f2116460620a231c744f5 - view on LGTM.com

new alerts:

  • 9 for Property access on null or undefined
  • 5 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 26 '22 19:07 lgtm-com[bot]

This pull request introduces 14 alerts and fixes 1 when merging 11e9b6aba158a049d66ab61a459174a39ddf00d2 into 23bf15d3ff33a5a7101f2116460620a231c744f5 - view on LGTM.com

new alerts:

  • 9 for Property access on null or undefined
  • 5 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 26 '22 21:07 lgtm-com[bot]

Codecov Report

Merging #10720 (1ce831d) into dev (9100adf) will decrease coverage by 0.02%. The diff coverage is 30.13%.

@@            Coverage Diff             @@
##              dev   #10720      +/-   ##
==========================================
- Coverage   47.43%   47.40%   -0.03%     
==========================================
  Files         673      674       +1     
  Lines       33274    33353      +79     
  Branches     6724     6729       +5     
==========================================
+ Hits        15782    15810      +28     
- Misses      15803    15851      +48     
- Partials     1689     1692       +3
Impacted Files Coverage Δ
...s/awscloudformation/utils/trigger-file-uploader.js 18.00% <0.00%> (ø)
...provider-awscloudformation/src/aws-utils/aws-s3.ts 14.96% <0.00%> (ø)
...ider-awscloudformation/src/upload-appsync-files.js 11.20% <0.00%> (ø)
...y-provider-awscloudformation/src/push-resources.ts 18.59% <7.84%> (-0.03%) :arrow_down:
...rovider-awscloudformation/src/aws-utils/aws-cfn.js 16.62% <21.62%> (+0.49%) :arrow_up:
...mation/src/aws-utils/aws-cfn-progress-formatter.ts 50.00% <50.00%> (ø)
...lify-provider-awscloudformation/src/initializer.ts 49.44% <72.22%> (-0.28%) :arrow_down:
...sting/lib/S3AndCloudFront/helpers/file-uploader.js 79.31% <100.00%> (ø)
...i/src/extensions/amplify-helpers/delete-project.ts 96.07% <100.00%> (ø)
...li/src/domain/amplify-usageData/getUsageDataUrl.ts 100.00% <0.00%> (+12.50%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 26 '22 22:07 codecov-commenter

This pull request introduces 5 alerts and fixes 1 when merging 60712ddd451fa81af837d34d9ccbc176d8b17d80 into 407687f23fb78cc71972fa75209db2ee27ebae1b - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 28 '22 18:07 lgtm-com[bot]

This pull request fixes 1 alert when merging 6992abc9f2ae81cbed515a1cbb203a6502d9bb00 into f154b898c25f97175fae21e906f85a277a4dafd9 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 28 '22 22:07 lgtm-com[bot]

This pull request fixes 1 alert when merging e407ba0d5feee774771f4bb33470239a8b608063 into f154b898c25f97175fae21e906f85a277a4dafd9 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 28 '22 23:07 lgtm-com[bot]

This pull request fixes 1 alert when merging 30d670332c2b5ce5fdde0979c4f9fd6ba603a40b into f154b898c25f97175fae21e906f85a277a4dafd9 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 29 '22 00:07 lgtm-com[bot]

This pull request fixes 1 alert when merging 4c9cbdca0882c0c11805bc53af751e33ff4e111d into f154b898c25f97175fae21e906f85a277a4dafd9 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 29 '22 01:07 lgtm-com[bot]

Addressed the last suggestion as well. Thank you @jhockett and @edwardfoyle . Appreciate your reviews and feedback for this PR.

sreekanth-sreekumar avatar Jul 29 '22 17:07 sreekanth-sreekumar

This pull request fixes 1 alert when merging 2258f8e1eed66fb96c798ab532757224967f277f into f154b898c25f97175fae21e906f85a277a4dafd9 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 29 '22 17:07 lgtm-com[bot]

This pull request fixes 1 alert when merging 63db448e0ab64e69d6f7d89f773ca3d164421466 into 523ffdbfe9c2c66a0520552d46e18e15b8ede20b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 01 '22 23:08 lgtm-com[bot]

This pull request fixes 1 alert when merging 78426c88fe1e179e20363a8caf542e05bc900dbc into 523ffdbfe9c2c66a0520552d46e18e15b8ede20b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 02 '22 16:08 lgtm-com[bot]

This pull request fixes 1 alert when merging a4724dd3767ff71a47fa4733c099445c076a7996 into 2b17187b42cc2352993259e20d39226a227ee200 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 03 '22 05:08 lgtm-com[bot]

This pull request fixes 1 alert when merging 7e7366b3b530fedc50ee2689e549168cc38e7f65 into 2b17187b42cc2352993259e20d39226a227ee200 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 03 '22 17:08 lgtm-com[bot]

This pull request fixes 1 alert when merging 155dbd545491159acb5db9d33350ec8b5cb27013 into 2b17187b42cc2352993259e20d39226a227ee200 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 03 '22 23:08 lgtm-com[bot]

This pull request fixes 1 alert when merging 5f13830b794916c208f8aae2db2aca0981cb926f into 2b17187b42cc2352993259e20d39226a227ee200 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 04 '22 17:08 lgtm-com[bot]

This pull request fixes 1 alert when merging b49e8ce40a1e1a612909216f54d62d027c76e37e into 9100adfbfe98311bacfaa84a9e195946fd078c56 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 09 '22 23:08 lgtm-com[bot]

This pull request fixes 1 alert when merging 2cb7097f5c659b9c59ea5d8045cf730aa964076e into 7c08e09502a882cfc927ef110d80264d862318d5 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 11 '22 20:08 lgtm-com[bot]

This pull request fixes 1 alert when merging 5cb96cf4b05261011d39939d2922bc2b517474da into 49bbf7ed24fe140bcc52db0d5fd464066b9328d2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 12 '22 16:08 lgtm-com[bot]

This pull request fixes 1 alert when merging 1ce831d3a1918c46f3f9f80a8c22c20b168b7288 into 49bbf7ed24fe140bcc52db0d5fd464066b9328d2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 12 '22 22:08 lgtm-com[bot]