gradientmaps icon indicating copy to clipboard operation
gradientmaps copied to clipboard

You cannot apply gradients with loop

Open sirpeas opened this issue 9 years ago • 1 comments

For example:

  var elemsWithGradients = document.querySelectorAll('[data-gradient]');

  for (var elem in elemsWithGradients) {
    if (elemsWithGradients.hasOwnProperty(elem)) {
      var gradient = elemsWithGradients[elem].dataset['gradient'];
      GradientMaps.applyGradientMap(elemsWithGradients[elem], gradient);
    }
  }

It's because filterID is a timestamp and sometimes it creates same id for few gradients. To solve this problem generate random unrepeatable number for filterID or use this:

generateID: function() {
  this.previousID = this.previousID + 1 || 0;
  return this.previousID;
},

and

filterID = 'filter-' + this.generateID();

Greetings!

sirpeas avatar Feb 09 '16 10:02 sirpeas

@awgreenblatt you can check and merge my pullrequest #6

sirpeas avatar Mar 28 '16 09:03 sirpeas