AvS_FastSimpleImport icon indicating copy to clipboard operation
AvS_FastSimpleImport copied to clipboard
verified publisher icon avstudnitz

Added fix for category positions

Open barbazul opened this issue 8 years ago • 4 comments

Fixes #281

This is not my solution, it's the solution provided by https://github.com/YouweGit/AvS_FastSimpleImport/commit/a4582527c2621ed54db1af89a4cb0506f204f58f with some minor fixes (an array key) and an update to the Main integration test.

I also deprecated the existing logic for calculating position as it was incompatible with YouweGit fixes

barbazul avatar Jun 07 '17 21:06 barbazul

I'm not working on Magento 1 anymore, but would be nice to get this solved/merged

mbijnsdorp avatar Jun 26 '17 06:06 mbijnsdorp

Thanks for your contribution. It is hard to understand though.

Could you base your commit on the latest development branch and propose a new PR to the development branch, please? The pull request should only show your commits and no others.

sprankhub avatar Jul 25 '17 14:07 sprankhub

Is this better?

barbazul avatar Jan 21 '18 00:01 barbazul

This is much better, thanks! Once someone is able to work on the issues again, it should be possible to merge this after successful testing.

sprankhub avatar Jan 24 '18 07:01 sprankhub