elm-program-test icon indicating copy to clipboard operation
elm-program-test copied to clipboard

Missed elm/json project on indirect dependencies.

Open Bernardoow opened this issue 6 years ago • 2 comments

Hi @avh4 !!

I started one poc project and happend a problem.

My steps

  1. elm init
  2. elm install elm-test
  3. create a simple test
  4. Run and test was ok.
  5. elm-test install avh4/elm-program-test
  6. Run and got a error about invalidt elm.json. Repo with bug

So I compared with another package my that everything works, so I started install some packages to find the problem.

I installed elm/http and it continued with the problem. So I installed a elm/json and the tests go back works. Repo without bug

Bernardoow avatar Sep 12 '19 15:09 Bernardoow

I suspect this is a problem with elm-test. Could you try using https://www.npmjs.com/package/elm-json with elm-json install --test avh4/elm-program-test instead of elm-test install avh4/elm-program-test and see if that works better?

avh4 avatar Sep 13 '19 02:09 avh4

Hi avh4!

I tested again with your sugestion and I got again the same error.

My steps:

  1. elm init
  2. elm install elm-test
  3. elm-test init
  4. elm-test => Run and test was ok.
  5. ./node_modules/elm-json/bin/elm-json install --test avh4/elm-program-test
-- PACKAGE CHANGES READY -------------------------------------------------------

I want to make some changes to your direct test dependencies

- [ADD] avh4/elm-program-test 3.1.0

I want to make some changes to your indirect test dependencies

- [ADD] avh4/elm-fifo 1.0.4
- [ADD] elm/bytes 1.0.8
- [ADD] elm/file 1.0.5
- [ADD] elm/http 2.0.0

Should I make these changes? yes

  1. elm-test => Run and got a error about invalid elm.json.
  2. ./node_modules/elm-json/bin/elm-json install elm/json
I want to make some changes to your direct dependencies

- [ADD] elm/json 1.1.3

I want to make some changes to your indirect dependencies

- [DEL] elm/json 1.1.3
  1. elm-test => Test pass now.

Bernardoow avatar Sep 16 '19 19:09 Bernardoow