avencera
Fix regex for parsing css classes
- Replace
class(Name)*withclass(Name)? - Add support for
(,),,, and#in class names
Thanks @DanikVitek, could you make a test. Thanks
Sorry for late response. I've added a few tests. (They were generated by phind)
@DanikVitek looks good thanks!, just solve conflicts and I will merge
The conflicts might be annoying to resolve, this was before the splitting of the libraries wasn't it.
For the tests: in a previous PR I added the test-case crate which might be nice to reduce the repetition in those assert statements (used here). Also I think there should be some failing tests, i.e. ones that don't match.
Sorry for the delay, It's the end of the semester and I need to deal with my studies. I might be able to get to fixing the conflicts the next week.
@praveenperera Seems to be fine. Though I'm not sure which failing test cases should I add
Nice, hopefully this gets merged soon.
Though I'm not sure which failing test cases should I add
To be honest it's probably fine, it should be caught by the other tests. But I meant just strings that it shouldn't match, like random strings or html/jsx elements without class(name) etc.