PyISY icon indicating copy to clipboard operation
PyISY copied to clipboard

New nodes added in the ISY require restart of module.

Open shbatm opened this issue 5 years ago • 1 comments

Right now an error is logged and message ignored if a new node is added to the ISY after the initial connection is made to the event stream.

This module should support live adding/removing of nodes from the ISY (especially with the move to ISYv5).

It shouldn't be too hard to implement, but would probably be best after moving to asyncio (or similar for true async comms -- see #53). I'm thinking if you get a _controlmsg for a node you don't know about, try calling rest/nodes/--unknown node-- and see if you get a good response. If so, add the node an process.

Originally posted by @shbatm in https://github.com/automicus/PyISY/pull/65/review_comment/create

shbatm avatar Mar 03 '20 03:03 shbatm

Just a note: I'll leave this open for now since it'd still be nice to support natively, but at least on the Home Assistant side: https://github.com/shbatm/hacs-isy994/releases/tag/v1.4.1 adds a reload service which can be called to refresh the whole module and pickup new nodes without a full restart.

shbatm avatar May 03 '20 12:05 shbatm