APIcasso icon indicating copy to clipboard operation
APIcasso copied to clipboard
verified publisher icon autoforce

[Security] Bump activestorage from 5.2.3 to 6.0.3.2

Open dependabot-preview[bot] opened this issue 5 years ago • 2 comments

Bumps activestorage from 5.2.3 to 6.0.3.2. This update includes a security fix.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Circumvention of file size limits in ActiveStorage There is a vulnerability in ActiveStorage's S3 adapter that allows the Content-Length of a direct file upload to be modified by an end user.

Versions Affected: rails < 5.2.4.2, rails < 6.0.3.1 Not affected: Applications that do not use the direct upload functionality of the ActiveStorage S3 adapter. Fixed Versions: rails >= 5.2.4.3, rails >= 6.0.3.1

Impact

Utilizing this vulnerability, an attacker can control the Content-Length of an S3 direct upload URL without receiving a new signature from the server. This could be used to bypass controls in place on the server to limit upload size.

Workarounds

This is a low-severity security issue. As such, no workaround is necessarily until such time as the application can be upgraded.

Patched versions: ~> 5.2.4.3; >= 6.0.3.1 Unaffected versions: none

Release notes

Sourced from activestorage's releases.

6.0.3.1

Active Support

  • [CVE-2020-8165] Deprecate Marshal.load on raw cache read in RedisCacheStore

  • [CVE-2020-8165] Avoid Marshal.load on raw cache value in MemCacheStore

Active Model

  • No changes.

Active Record

  • No changes.

Action View

  • [CVE-2020-8167] Check that request is same-origin prior to including CSRF token in XHRs

Action Pack

  • [CVE-2020-8166] HMAC raw CSRF token before masking it, so it cannot be used to reconstruct a per-form token

  • [CVE-2020-8164] Return self when calling #each, #each_pair, and #each_value instead of the raw @parameters hash

Active Job

  • No changes.

Action Mailer

  • No changes.

Action Cable

  • No changes.

Active Storage

... (truncated)
Changelog

Sourced from activestorage's changelog.

Rails 6.0.3.2 (June 17, 2020)

  • No changes.

Rails 6.0.3.1 (May 18, 2020)

  • [CVE-2020-8162] Include Content-Length in signature for ActiveStorage direct upload

Rails 6.0.3 (May 06, 2020)

  • No changes.

Rails 6.0.2.2 (March 19, 2020)

  • No changes.

Rails 6.0.2.1 (December 18, 2019)

  • No changes.

Rails 6.0.2 (December 13, 2019)

  • No changes.

Rails 6.0.1 (November 5, 2019)

  • ActiveStorage::AnalyzeJobs are discarded on ActiveRecord::RecordNotFound errors.

    George Claghorn

  • Blobs are recorded in the database before being uploaded to the service. This fixes that generated blob keys could silently collide, leading to data loss.

    Julik Tarkhanov

Rails 6.0.0 (August 16, 2019)

  • No changes.

Rails 6.0.0.rc2 (July 22, 2019)

  • No changes.
... (truncated)
Commits
  • fbe2433 Preparing for 6.0.3.2 release
  • 34991a6 Preparing for 6.0.3.1 release
  • 2c8fe2a bumping version, updating changelog
  • 0ad524a update changelog
  • 17507e8 Include Content-Length in signature for ActiveStorage direct upload
  • b738f19 Preparing for 6.0.3 release
  • 509b9da Preparing for 6.0.3.rc1 release
  • 7aea213 Verify FFmpeg presence before attempting to preview videos
  • 88c97f8 Fix autosave association bug with ActiveStorage::Attachments
  • b60571e Merge pull request #38864 from abhaynikam/replace-mailing-list-url
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

dependabot-preview[bot] avatar Jun 18 '20 05:06 dependabot-preview[bot]

Dependabot tried to add @ervalhous as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/autoforce/APIcasso/pulls/133/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the autoforce/APIcasso repository. // See: https://developer.github.com/v3/pulls/review_requests/#create-a-review-request

dependabot-preview[bot] avatar Jun 18 '20 05:06 dependabot-preview[bot]

Codecov Report

Merging #133 into master will decrease coverage by 85.59%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #133       +/-   ##
===========================================
- Coverage   96.99%   11.40%   -85.60%     
===========================================
  Files          24       15        -9     
  Lines         931      614      -317     
===========================================
- Hits          903       70      -833     
- Misses         28      544      +516
Impacted Files Coverage Δ
spec/requests/singularized/requests_spec.rb 1.87% <0.00%> (-97.50%) :arrow_down:
...equests/plurarized/requests_with_plurarize_spec.rb 1.87% <0.00%> (-97.50%) :arrow_down:
spec/token/token_spec.rb 4.23% <0.00%> (-95.77%) :arrow_down:
spec/requests/batch_spec.rb 6.12% <0.00%> (-93.88%) :arrow_down:
spec/requests/singularized/bad_requests_spec.rb 12.50% <0.00%> (-87.50%) :arrow_down:
...sts/plurarized/bad_requests_with_plurarize_spec.rb 12.50% <0.00%> (-87.50%) :arrow_down:
spec/models/used_model_spec.rb 41.17% <0.00%> (-58.83%) :arrow_down:
app/models/apicasso/key.rb 63.63% <0.00%> (-36.37%) :arrow_down:
spec/apicasso_spec.rb 66.66% <0.00%> (-33.34%) :arrow_down:
spec/dummy/app/models/used_model.rb 46.15% <0.00%> (-15.39%) :arrow_down:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a95b5fc...dc35565. Read the comment docs.

codecov-commenter avatar Jun 18 '20 05:06 codecov-commenter