Enable `go vet`'s linters
The golangci-lint configuration doesn't currently include go vet's lint rules. There's a set of problems that can be caught by static analysis that won't be caught by the compiler, such as errors.As invocations where errors.As takes an any as its second arg.
We ran go vet ./... on the repo as a test, and it seems like most of the work here will be either reordering fields or adding names to structs whose order of instantiated fields don't match their order of declared fields, mostly in tests.
1. go vet No Output
I am running go vet ./... but no output is shown
2. .golangci.yaml file has go vet commented out
@subrajeet-maharana we, the maintainers, added the - "govet" TODO: fix issues line 😄 If you want to contribute you can help us by uncommenting that line and then fixing all reported. Thanks!
Someone is working on this?
@rkgarcia / @miparnisari I'm picking this one up today, enabling all TODO'd modules and working through them here. Should be finished by EOD.
Edit: https://github.com/authzed/spicedb/pull/2455 is out for review.