zerocode icon indicating copy to clipboard operation
zerocode copied to clipboard

remove maven-compiler warnings with target Java 17

Open baulea opened this issue 2 years ago • 2 comments

Although the project code is not runnable with JDK17 at the moment, I would like to fix some warnings the Java 17 compiler shows up. The changes are compatible with Java 8.

I would appreciate if you assign this issue to me.

[WARNING] /home/alois/zerocode/core/src/main/java/org/jsmart/zerocode/core/kafka/helper/KafkaProducerHelper.java:[102,62] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.Class<?> for a varargs call
  cast to java.lang.Class<?>[] for a non-varargs call and to suppress this warning
[WARNING] /home/alois/zerocode/core/src/main/java/org/jsmart/zerocode/core/kafka/helper/KafkaProducerHelper.java:[103,50] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.Object for a varargs call
  cast to java.lang.Object[] for a non-varargs call and to suppress this warning

  WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java:[21,39] Integer(java.lang.String) in java.lang.Integer has been deprecated and marked for removal
[WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java:[21,57] Long(java.lang.String) in java.lang.Long has been deprecated and marked for removal
[WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java:[22,39] Integer(java.lang.String) in java.lang.Integer has been deprecated and marked for removal
[WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/assertion/NumberComparatorTest.java:[22,57] Double(java.lang.String) in java.lang.Double has been deprecated and marked for removal
[WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/runner/ZeroCodeUnitRuntimeAnnoTest.java:[57,78] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.Class<?> for a varargs call
  cast to java.lang.Class<?>[] for a non-varargs call and to suppress this warning
[WARNING] /home/alois/zerocode/core/src/test/java/org/jsmart/zerocode/core/engine/executor/javaapi/JavaMethodExecutorImplTest.java:[90,83] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to java.lang.Object for a varargs call
  cast to java.lang.Object[] for a non-varargs call and to suppress this warning

baulea avatar Oct 28 '23 10:10 baulea

Hi @authorjapps, the PR #604 could be merged into master. It is fully compatible with JDK8.

baulea avatar Nov 24 '23 17:11 baulea

Hi @authorjapps, is there anything else I should do? Or are we just waiting for a reviewer to review the PR?

baulea avatar Dec 19 '23 14:12 baulea

This issue has already been done with PR https://github.com/authorjapps/zerocode/pull/604

baulea avatar Mar 16 '24 16:03 baulea