zerocode icon indicating copy to clipboard operation
zerocode copied to clipboard

OAuth2 supported HttpClient in core module

Open santhoshTpixler opened this issue 7 years ago • 4 comments

Background:

We have an OAuth2 in action #186 in the authorjapps/zerocode-hello-world#7 repo. But it can be made as part of the core module. Since the OAuth2 implementation was generic enough to support most of the providers it will benefit many people.

AC1:

Follow this as reference or suggestion only(but check the latest IETF doc for standard impl): https://github.com/authorjapps/zerocode/pull/676#pullrequestreview-2274484012

  • Internet Engineering Task Force (IETF) standard

AC2:

  • Log (WARN level) the access_token details or log the response
  • Log (WARN level) client_id and client_secret by masking it (e.g. for "secret123", log "s***3"or "***" to avoid extra logic)

and

  • Log (INFO level) client_id and client_secret as it is(without any masking)

santhoshTpixler avatar Jan 19 '19 13:01 santhoshTpixler

Hi @santhoshTpixler . What needs to be done to get this working. I will like to contribute.

agbanagba avatar Aug 26 '19 15:08 agbanagba

@agbanagba You are welcomed to contribute. :+1: As mentioned above in the issue, we have the Oauth2 supported HTTP client in the example repo. It has to move into the core project. I am not sure the example implementation is the standard one.

santhoshTpixler avatar Aug 27 '19 03:08 santhoshTpixler

Thats cool. I will be working on it. Thanks

agbanagba avatar Aug 28 '19 23:08 agbanagba