auth0.net icon indicating copy to clipboard operation
auth0.net copied to clipboard

Add show_as_button to organizations connection

Open jpealing-fiscaltec opened this issue 1 year ago • 1 comments

Changes

Adds show_as_button to OrganizationConnection, OrganizationConnectionCreateRequest and OrganizationConnectionUpdateRequest.

References

This property is documented here:

Testing

I have attempted to add a unit test by following the pattern used for AssignMembershipOnLogin, however I was not able to run the tests to validate that they passed.

  • [ ] This change adds unit test coverage

  • [X] This change adds integration test coverage

  • [ ] This change has been tested on the latest version of the platform/language or why not

Checklist

jpealing-fiscaltec avatar Mar 18 '24 20:03 jpealing-fiscaltec

Thanks 👍 Ignore the failing CI, will look into it. PR looks good 🙏 🔥

frederikprijck avatar Mar 19 '24 11:03 frederikprijck

Any update on when this is likely to be merged?

jpealing-fiscaltec avatar Apr 02 '24 08:04 jpealing-fiscaltec

Sorry, lost track of this. Let me fix CI and look into merging and releasing this.

frederikprijck avatar Apr 02 '24 09:04 frederikprijck

Tests are failing because the property is only supported for Enterprise Connections. I will revert the changes to the test and move forward without the tests, testing enterprise-only features are not always that trivial.

frederikprijck avatar Apr 02 '24 09:04 frederikprijck