auth0-java icon indicating copy to clipboard operation
auth0-java copied to clipboard

Make DefaultHttpClient extensible, Issue #754

Open noetro opened this issue 5 months ago • 1 comments

Changes

The package scoped constructor of DefaultHttpClient has been made protected so that custom implementations can extend DefaultHttpClient to provide a pre-build OkHttp client delegate.

I considered making the constructor public so we didn't need to extend, but that felt like a step too far and leaks to the world that the DefaultHttpClient implementation is using OkHttp

References

Please include relevant links supporting this change such as a:

https://github.com/auth0/auth0-java/issues/754

Testing

The existing automated tests run.

  • [ ] This change adds test coverage
  • [X] This change has been tested on the latest version of the platform/language

Checklist

noetro avatar Aug 25 '25 10:08 noetro

Hi @noetro

Thank you for raising the PR, I'll review it shortly.

tanya732 avatar Sep 03 '25 16:09 tanya732