angular2-jwt icon indicating copy to clipboard operation
angular2-jwt copied to clipboard

Upgrade angular to v11

Open celian-garcia opened this issue 4 years ago • 5 comments

Hi, thanks for this library, I'm planning to update progressively until Angular v13, with one commit by Angular version (one for v11, on for v12, one for v13). I plan to move linter to eslint in the Angular v12 commit. Please tell me if you agree with these changes and thus if I can continue or not.

The objective is at the end to get rid of the warning in v13 https://github.com/auth0/angular2-jwt/issues/712

Cheers!

Changes

  • Upgraded Angular to v11 using ng update

References

  • Probably fixes this https://github.com/auth0/angular2-jwt/issues/697, even though I think it works perfectly with Angular 11 as we ran our frontend on Angular 11 without issue for monthes.

Checklist

celian-garcia avatar Jan 05 '22 15:01 celian-garcia

why this taking so long?

PedroS5499 avatar Mar 03 '22 14:03 PedroS5499

why this taking so long?

I agree it's a bit long, I'm wondering if it's still maintained. To be honest I'm considering making a fork.

Hello @Sambego, sorry I mention you as you are the last commiter. I'd like to remind you the fact that Angular 10 is not anymore an LTS, and so doesn't receive any security updates, according to the Angular Support Policy documentation. image

If Auth0 still uses this project, it should be updated for sure!

celian-garcia avatar Mar 05 '22 07:03 celian-garcia

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

stale[bot] avatar Jun 12 '22 14:06 stale[bot]

No no, no stale

PedroS5499 avatar Jun 12 '22 15:06 PedroS5499

@PedroS5499 did you find a substitute ? I don't want to maintain a fork so I will search for another lib or maybe integrate stuff in my code place.

celian-garcia avatar Jul 07 '22 06:07 celian-garcia

Closing this in favor of https://github.com/auth0/angular2-jwt/issues/712

frederikprijck avatar Sep 21 '22 07:09 frederikprijck