workflow-dispatch icon indicating copy to clipboard operation
workflow-dispatch copied to clipboard

chore: upgrade libs, node 20

Open sammcj opened this issue 2 years ago • 4 comments

Upgraded repo to support current stable nodeJS and libraries.

  • node 16 -> node 20
  • actions-github v5 -> v6
  • corrected input types (true != "true")

sammcj avatar Nov 15 '23 22:11 sammcj

Hi @aurelien-baudet , any updates on this PR please? Thanks.

iamludal avatar Dec 13 '23 15:12 iamludal

What's the status of the PR ?

Also, there is a warning with the action:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

VincentLanglet avatar Feb 21 '24 08:02 VincentLanglet

Also wondering if there is any update on this?

MugishaU avatar Mar 18 '24 12:03 MugishaU

Sorry, I have no more time and energy to maintain this repository. I even don't have computer anymore. Someone of you should for this repository and merge the different pull requests. Tell me who creates the fork and I will archive this repository but indicate which repository follows up

aurelien-baudet avatar May 10 '24 06:05 aurelien-baudet

Hi @aurelien-baudet, I have created a fork of your repository that I can maintain. https://github.com/iamludal/workflow-dispatch

iamludal avatar May 14 '24 07:05 iamludal

Hi @aurelien-baudet, I have created a fork of your repository that I can maintain. iamludal/workflow-dispatch

Does this project really need another fork when there is already the original repository ? https://github.com/benc-uk/workflow-dispatch

The original repository seems still maintained. Is there a reason to not for moving to it ?

VincentLanglet avatar May 14 '24 07:05 VincentLanglet

Hi @aurelien-baudet, I have created a fork of your repository that I can maintain. iamludal/workflow-dispatch

Does this project really need another fork when there is already the original repository ? https://github.com/benc-uk/workflow-dispatch

The original repository seems still maintained. Is there a reason to not for moving to it ?

Yes, this fork from @aurelien-baudet adds some inputs to wait for the workflow completion before exiting. In the original repository, the workflow is triggered and exits successfully immediately.

iamludal avatar May 14 '24 15:05 iamludal

Yes, this fork from @aurelien-baudet adds some inputs to wait for the workflow completion before exiting. In the original repository, the workflow is triggered and exits successfully immediately.

Thanks for the answer.

IMHO the best, if possible, would be to add those inputs in the original repository which are well maintained.

I'll ask the original repo if he's interested https://github.com/benc-uk/workflow-dispatch/issues/73

VincentLanglet avatar May 14 '24 16:05 VincentLanglet

Yes, this fork from @aurelien-baudet adds some inputs to wait for the workflow completion before exiting. In the original repository, the workflow is triggered and exits successfully immediately.

Thanks for the answer.

IMHO the best, if possible, would be to add those inputs in the original repository which are well maintained.

I'll ask the original repo if he's interested benc-uk#73

I agree with you, I would prefer this solution over having to maintain a fork myself. I can do it if needed, but this is not the best solution.

iamludal avatar May 15 '24 07:05 iamludal

Repository transferred to https://github.com/the-actions-org/workflow-dispatch

aurelien-baudet avatar May 25 '24 06:05 aurelien-baudet

These issues were resolved in https://github.com/the-actions-org/workflow-dispatch/pull/18

fbiesse avatar Jun 21 '24 08:06 fbiesse