aurae icon indicating copy to clipboard operation
aurae copied to clipboard

Call to `Cell.free` in tests hang

Open future-highway opened this issue 3 years ago • 4 comments

Right now any test (2 currently) that calls free on a Cell seems to hang. I thought this would be solved when proxying SIGTERM to the nested auraed, but that did not happen.

Note: Using auraescript to free a Cell does not result in this issue.

future-highway avatar Jan 02 '23 15:01 future-highway

this suggests the test harness is intersecting the signals somehow, at a first guess.

dmah42 avatar Jan 02 '23 15:01 dmah42

Update: the tests were using a default SharedNamespaces struct which defaults to false for all namespaces. Flipping this, to share all namespaces, makes all the tests pass.

Edit: We no longer have a SharedNamespaces struct. It has been replaced with a IsolationControls struct, which also unshares namespaces and results in the same problem.

future-highway avatar Jan 07 '23 17:01 future-highway

Is this still an issue? All ignored tests in auread pass for me. Which 2 tests is this issue referring to?

JeroenSoeters avatar Jan 23 '23 02:01 JeroenSoeters

I think so. I definitely still have issues if I flip the isolation controls to true. I was also getting intermittent hangs as is (but that may have resolved itself with recent changes to the module).

future-highway avatar Jan 23 '23 13:01 future-highway