deezer-linux icon indicating copy to clipboard operation
deezer-linux copied to clipboard

Hiding a DOM element with useless warning (blocked trackers)

Open ElysaSrc opened this issue 8 months ago • 3 comments

I've noticed that when using the application with a DNS level blocker I have the following banner that is spammed when it cannot contact a tracker:

Image

I guess this is due to a network failure catch-all that does not separate fatal network errors and non-fatal network erros (trackers etc...).

We could add an option to use and hide the following CSS selector by injecting it in the app:

.alert-wrapper:has(> div[data-testid=\"alert-AppOffline\"])

If that's looks good to you, I'm okay with trying to do the PR.

ElysaSrc avatar May 23 '25 11:05 ElysaSrc

I think that could be ok to do, but only as an optional argument: this is quite an important functionality (being told that we are online), and even if it does not work well for me either and the purpose is not striking, removing it would make the app a bit different no?

I mean I'm not sure either, maybe just removing this badge altogether would be ok (and is a lot simpler of course), just my opinion

aunetx avatar May 24 '25 21:05 aunetx

(sorry, you indeed talked about an option, so I'm totally OK with you trying that and if you don't make it I could try too)

aunetx avatar May 24 '25 21:05 aunetx

I added that in #124, if you want to test it, it should suit your needs!

aunetx avatar May 26 '25 14:05 aunetx