audtorch icon indicating copy to clipboard operation
audtorch copied to clipboard

Remove scipy from code?

Open hagenw opened this issue 6 years ago • 2 comments

With not including librosa in the dependencies we had the problem of #50. In the end, we added it to setup.cfg.

We still have a hidden dependency on scipy, which is not listed in setup.cfg, and I'm reluctant to add it there. It is used as a non-default option in transforms.Resample. My question is: should we just stay with it, or maybe remove the scipy resample option altogether as it can crash as well?

hagenw avatar Nov 14 '19 08:11 hagenw

If I remember correctly this was the fastest options for small files, right?

ATriantafyllopoulos avatar Nov 14 '19 09:11 ATriantafyllopoulos

Yes, it was. But at the moment the recommended workflow is to do the resampling first anyway.

hagenw avatar Nov 14 '19 10:11 hagenw