devtools-remote icon indicating copy to clipboard operation
devtools-remote copied to clipboard

Use correct versionized DevTool front-end

Open auchenberg opened this issue 10 years ago • 5 comments

Different versions of Chrome supports different features in DevTools, in order to make DevTools Remote work in current and future versions, then it should load the correct versionized DevTool front-end.

Steps:

  • Detect WebKit Version
  • Send that to API when creating a new session
  • Load correct front-end version

auchenberg avatar Jan 21 '16 01:01 auchenberg

You may want to detect the Blink version, rather than the WebKit version :)

kurtextrem avatar Jan 21 '16 19:01 kurtextrem

The property is actually still called Webkit-Version as per https://code.google.com/p/chromium/codesearch#chromium/src/components/devtools_http_handler/devtools_http_handler.cc&q=Webkit-versio&sq=package:chromium&type=cs&l=566

auchenberg avatar Jan 21 '16 19:01 auchenberg

Oh, well then. My bad!

kurtextrem avatar Jan 21 '16 20:01 kurtextrem

I tried having a Canary (58) connect to current stable (56) and it didn't work so great. There was some flickering on the image. https://github.com/auchenberg/devtools-remote/blob/master/server.js#L111 'chrome-devtools://devtools/remote/serve_rev/@d19c087b9bfdf76a8af91e2f0a0e791bf2ffcafa/inspector.html?ws=' + webSocketUrl + '&remoteFrontend=true&dockSide=unlocked&experiments=true'

It looks like you hard coded in a revision. Can you describe the process by which you selected that revision?

kzahel avatar Mar 03 '17 01:03 kzahel

@kzahel The DevTools version is selected on a per-commit basis. No special policy or process.

auchenberg avatar Apr 05 '17 22:04 auchenberg