feat: Ensure init-containers are consistently used throughout every chart for dependency checks
We need to ensure that every chart consistently leverages the init-container approach.
An example of where we are doing it correctly:
https://github.com/att-comdev/openstack-helm/blob/master/keystone/templates/deployment.yaml#L11-L40
An example of something that needs conversion:
https://github.com/att-comdev/openstack-helm/blob/master/neutron/templates/deployment-server.yaml#L14-L34
Also relates to https://github.com/att-comdev/openstack-helm/issues/69
@alanmeadows great you've got this! was going to raise it. :)
As part of this effort, we also need to remove unnecessary environment variables, e.g. in https://github.com/att-comdev/openstack-helm/pull/84/files/4d1b5320f7864462657fe93df498b3e3c4db6bca#diff-54d43c699714abd5ec5ca3feb92891ae
and
https://github.com/att-comdev/openstack-helm/pull/84/files/4d1b5320f7864462657fe93df498b3e3c4db6bca#diff-c0d64fde17ec142ec961ff923c191027
@alanmeadows if you're not currently working on this, I can take it over as part of the refactoring I'm doing since yesterday on the initial chart for neutron.
@Ciello89 It's all yours, this will be a great consistency/cleanup win.
@alanmeadows I've done this as part of https://github.com/att-comdev/openstack-helm/pull/138
Folks, as init-containers are going to be moved out of beta in K8S 1.6 we should ensure that our charts would be able to handle both of them. We should go even further with init-container template to included event the calling statement in the common package (so we can have have condition on k8s version in a single place).