openstack-helm icon indicating copy to clipboard operation
openstack-helm copied to clipboard

feat: Ensure init-containers are consistently used throughout every chart for dependency checks

Open alanmeadows opened this issue 9 years ago • 7 comments

We need to ensure that every chart consistently leverages the init-container approach.

An example of where we are doing it correctly:

https://github.com/att-comdev/openstack-helm/blob/master/keystone/templates/deployment.yaml#L11-L40

An example of something that needs conversion:

https://github.com/att-comdev/openstack-helm/blob/master/neutron/templates/deployment-server.yaml#L14-L34

alanmeadows avatar Jan 04 '17 17:01 alanmeadows

Also relates to https://github.com/att-comdev/openstack-helm/issues/69

alanmeadows avatar Jan 05 '17 01:01 alanmeadows

@alanmeadows great you've got this! was going to raise it. :)

intlabs avatar Jan 05 '17 13:01 intlabs

As part of this effort, we also need to remove unnecessary environment variables, e.g. in https://github.com/att-comdev/openstack-helm/pull/84/files/4d1b5320f7864462657fe93df498b3e3c4db6bca#diff-54d43c699714abd5ec5ca3feb92891ae

and

https://github.com/att-comdev/openstack-helm/pull/84/files/4d1b5320f7864462657fe93df498b3e3c4db6bca#diff-c0d64fde17ec142ec961ff923c191027

alanmeadows avatar Jan 05 '17 18:01 alanmeadows

@alanmeadows if you're not currently working on this, I can take it over as part of the refactoring I'm doing since yesterday on the initial chart for neutron.

Ciello89 avatar Jan 05 '17 19:01 Ciello89

@Ciello89 It's all yours, this will be a great consistency/cleanup win.

alanmeadows avatar Jan 05 '17 19:01 alanmeadows

@alanmeadows I've done this as part of https://github.com/att-comdev/openstack-helm/pull/138

intlabs avatar Jan 22 '17 22:01 intlabs

Folks, as init-containers are going to be moved out of beta in K8S 1.6 we should ensure that our charts would be able to handle both of them. We should go even further with init-container template to included event the calling statement in the common package (so we can have have condition on k8s version in a single place).

ss7pro avatar Feb 13 '17 14:02 ss7pro