atomic-server icon indicating copy to clipboard operation
atomic-server copied to clipboard

Earthly tasks doing duplicate jobs

Open joepio opened this issue 2 years ago • 0 comments

I noticed that various actions in the earthfile are compiling stuff.

               +test |
               +test |    Compiling clap v4.0.26
               +test |
               +test |    Compiling tantivy-fst v0.4.0
               +lint |     Checking zstd v0.11.2+zstd.1.5.2
               +lint |
               +test |    Compiling bitpacking v0.8.4
               +lint |     Checking actix-http v3.2.1
               +lint | warning: `atomic_lib` (lib test) generated 1 warning (run `cargo clippy --fix --lib -p atomic_lib --tests` to apply 1 suggestion)  +lint |
               +lint |     Checking zstd v0.12.4
               +lint |
               +lint |     Checking tantivy-sstable v0.2.0
               +lint |
              +build |    Compiling phf v0.10.1
              +build |
               +lint |     Checking tantivy-columnar v0.2.0
              +build |    Compiling string_cache v0.8.4

I think that's because the +source action doesn't actually compile anything:

source:
  FROM +install
  COPY --keep-ts Cargo.toml Cargo.lock ./
  COPY --keep-ts --dir server lib cli  ./
  COPY browser+build/dist /code/browser/data-browser/dist
  DO rust+CARGO --args=fetch

So perhaps it should not fetch but build or check? I'm not sure.

joepio avatar Jan 30 '24 16:01 joepio