language-typescript icon indicating copy to clipboard operation
language-typescript copied to clipboard

With tree-sitter enabled, module imports no longer have syntax--import css class

Open ryanolsonx opened this issue 7 years ago • 0 comments

Prerequisites

  • [ X] Put an X between the brackets on this line if you have done all of the following:
    • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
    • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
    • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
    • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
    • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

When you enable tree-sitter parser, an import statement in a typescript file no longer has a css class "syntax--import." In atom/solarized-dark-syntax and atom/solarized-light-syntax, we theme the import line differently. If the "syntax--import" class is no longer there, we're unable to theme those lines as before.

Steps to Reproduce

  1. Enable tree-sitter parser
  2. Inspect typescript file that has a line such as import * as React from "react";

Expected behavior: Some indication that import, as, and from are "import" keywords.

Actual behavior: No indication that they are "import" related.

Reproduces how often: 100%

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

ryanolsonx avatar Jun 22 '18 15:06 ryanolsonx